fix(Conftest): Error: configmap references non-existent config key #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 70.62% 70.76% +0.13%
==========================================
Files 62 62
Lines 4024 4019 -5
==========================================
+ Hits 2842 2844 +2
+ Misses 873 868 -5
+ Partials 309 307 -2
Continue to review full report at Codecov.
|
When we created a scan Job for config audits it referred directly to the starboard-conftest-config ConfigMap. However, the ConfigMap might have changed before the Job was run. When we removed a policy from the ConfigMap the Job got stuck in the Pending state due to non-existent config key error. The solution is to copy policies to a temporary Secret and associate it with the scan Job so we're agnostic to changes of the starboard-conftest-config ConfigMap. Resolves: #509 Signed-off-by: Daniel Pacak <[email protected]>
danielpacak
requested review from
itaysk and
deven0t
and removed request for
itaysk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we created a scan Job for config audits it referred directly
to the starboard-conftest-config ConfigMap. However, the ConfigMap
might have changed before the Job was run. When we removed a policy
from the ConfigMap the Job got stuck in the Pending state due to
non-existent config key error.
The solution is to copy policies to a temporary Secret and associate
it with the scan Job so we're agnostic to changes of the
starboard-conftest-config ConfigMap.
Resolves: #509
Signed-off-by: Daniel Pacak [email protected]