Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy 2.2.2 test #61

Merged
merged 2 commits into from
Sep 3, 2020
Merged

tidy 2.2.2 test #61

merged 2 commits into from
Sep 3, 2020

Conversation

yoavrotems
Copy link
Contributor

make 2.2.2 output more tidy with the use of grep

make 2.2.2 output more tidy with the use of grep
@yoavrotems yoavrotems self-assigned this Sep 2, 2020
@yoavrotems yoavrotems added the bug Something isn't working label Sep 2, 2020
@yoavrotems yoavrotems linked an issue Sep 2, 2020 that may be closed by this pull request
@yoavrotems yoavrotems requested a review from lizrice September 2, 2020 13:13
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   21.39%   21.39%           
=======================================
  Files           4        4           
  Lines         187      187           
=======================================
  Hits           40       40           
  Misses        144      144           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d824e...ad10ef1. Read the comment docs.

Output was too long,
with apt-cache policy there is less output and we only take the line of contains Installed info and the one before (package name)
constraints:
platform:
- ubuntu18
tests:
tests:
bin_op: or
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we also take the line before "Installed: (none)" - aka the package name we check if Installed present and then check its (none) or it isn't present at all then its the package name which is OK

@yoavrotems yoavrotems changed the title tidy 2.2.2 output tidy 2.2.2 test Sep 3, 2020
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least for platforms where apt is used (do we need an issue to track getting this to work for other package managers?)

@yoavrotems yoavrotems merged commit cc3954e into master Sep 3, 2020
@yoavrotems yoavrotems deleted the tidy-2.2.2-output branch September 6, 2020 07:26
deven0t pushed a commit to deven0t/linux-bench that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test 2.2.2 output too long
2 participants