-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy 2.2.2 test #61
tidy 2.2.2 test #61
Conversation
make 2.2.2 output more tidy with the use of grep
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 21.39% 21.39%
=======================================
Files 4 4
Lines 187 187
=======================================
Hits 40 40
Misses 144 144
Partials 3 3 Continue to review full report at Codecov.
|
Output was too long, with apt-cache policy there is less output and we only take the line of contains Installed info and the one before (package name)
constraints: | ||
platform: | ||
- ubuntu18 | ||
tests: | ||
tests: | ||
bin_op: or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we also take the line before "Installed: (none)" - aka the package name we check if Installed present and then check its (none) or it isn't present at all then its the package name which is OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, at least for platforms where apt is used (do we need an issue to track getting this to work for other package managers?)
Fix the problem with multiple choices
make 2.2.2 output more tidy with the use of grep