-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fa_coin and your_fungible_asset #600
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just clean up those two issues
* @param admin - The account that deployed the fungible asset module. | ||
* @returns The name of the token as a string. | ||
*/ | ||
async function fetchTokenName(aptos: Aptos, admin: Account): Promise<string> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples use a "global" aptos object, so it doesn't have to be passed here
); | ||
|
||
console.log("Alice freezes Bob's account."); | ||
const freezeTransactionHash = await freeze(alice, bob.accountAddress); | ||
await aptos.waitForTransaction({ transactionHash: freezeTransactionHash }); | ||
|
||
console.log( | ||
"Alice as the admin forcefully transfers the newly minted coins of Charlie to Bob ignoring that Bob's account is frozen.", | ||
`Alice as the admin forcefully transfers the newly minted coins of Charlie to Bob ignoring that Bob's account is frozen.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace with "
Description
Updates the example code used in the "Your First Fungible Asset" tutorial in order to make it customizable. That way during the updated tutorial, you can change the name of the asset and see what the result is on-chain.
Test Plan
I tested locally to verify that the fa_coin still deployed and executed transactions correctly, but now the updated
your_fungible_asset
script actually looks up theASSET_NAME
.Related Links
Checklist
pnpm fmt
?CHANGELOG.md
? (Not needed)