Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub accounts #596

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Sub accounts #596

wants to merge 26 commits into from
+3,326 −1,035

Conversation

chiumax
Copy link
Member

@chiumax chiumax commented Nov 27, 2024

Description

Test Plan

Related Links

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@chiumax chiumax requested a review from hardsetting November 27, 2024 19:37
@hardsetting
Copy link
Contributor

Let's rebase on main, then possibly split this up into more focused PRs if possible?
I see some refactors that introduce a bit of noise

@hardsetting
Copy link
Contributor

hardsetting commented Dec 4, 2024 •
edited
Loading

Messaged offline, let's clean up this PR or just incorporate these changes into #596

a few notes:

  • let's have refactors or unrelated changes in a separate PR, it makes it difficult to review when most of the changes are not related to the scope of the PR (sub accounts in this case)
  • let's make it ready for review i.e. remove temporary stuff and commented code blocks / hardcoded values

@kaw2k kaw2k mentioned this pull request Dec 12, 2024
Merged
@kaw2k kaw2k force-pushed the sub-accounts branch 2 times, most recently from 97d3baf to d7e7a56 Compare December 19, 2024 15:27
runtian-zhou and others added 22 commits December 20, 2024 13:53
@runtian-zhou @kaw2k
Revert "[script-composer] Revert script composers (#574)"
57254ac 
This reverts commit bf8afa1.
@runtian-zhou @kaw2k
update deps
3102c3f
@0xmaayan @kaw2k
tag version
f931d81
@runtian-zhou @kaw2k
Update package.json
8990e25
@0xmaayan @kaw2k
bump version
8ac1128
@runtian-zhou @kaw2k
Update build.ts
26390ed
@kaw2k
bump
62644a7
@chiumax @kaw2k
export abstractedaccount
bd7a7ef
@kaw2k
starts to add static function to generate account from private key
531b449
@kaw2k
Adds watch script
11bcd1b
@kaw2k
starts to modify example
3ddb2ad
@kaw2k
Adds new test file to the ts-sdk
fd720fc
@kaw2k
Cleans up test file
0ef8e68
@kaw2k
Messing with tests
f7b42c0
@kaw2k
bump
fb0b08f
@kaw2k
Tests working again
8df1455
@kaw2k
Light test refactoring
d2b8264
@kaw2k
Adds viewing balance and permissions test
a54b1c0 
bump
@kaw2k
Refactors tests for granting multiple permissions
19fd358
@kaw2k
Updates to the test case
c575883
@chiumax @kaw2k
Permissioned Accounts (#594)
13157fd 
* Adds stubs for permission work

* someone fucking cooked here

* works

* all the tests pass

* organize

* respond to some comments

* use parsed permission

* fix test file

* fix

* all tests pass

---------

Co-authored-by: Rasa Welcher <[email protected]>
@kaw2k
Converts permissions to a serializable class (#604)
79ed37e 
* Converts permissions to a serializable class

* updates import

* Converts to single object argument approach

* More work

* Fixes dependency cycle

* Formats code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardsetting hardsetting Awaiting requested review from hardsetting

At least 2 approving reviews are required to merge this pull request.

Assignees

@kaw2k kaw2k

@chiumax chiumax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chiumax @hardsetting @kaw2k @runtian-zhou @0xmaayan