[account] Fix pagination on AccountModules and AccountResources #581
Conversation
| @@ -159,3 +159,45 @@ export async function paginateWithCursor<Req extends Record<string, any>, Res ex | |||
| } while (cursor !== null && cursor !== undefined); | |||
| return out as Res; | |||
| } | |||
|
|
|||
| /// This function is a helper for paginating using a function wrapping an API using offset instead of start | |||
| export async function paginateWithObfuscatedCursor<Req extends Record<string, any>, Res extends Array<{}>>( | |||
There was a problem hiding this comment.
iiuc, the only 2 differences is the start vs offset param and the re-evaluate length calculation - any reason not to simply use the existing paginateWithCursor but just provide a flag for the re-evaluate length calculation part? requestParams are already being passed as an argument to the paginateWithCursor function.
There was a problem hiding this comment.
I wanted to be more explicit because the start vs offset is actually more of the problem that the one with the obfuscated cursor is not useful / a user shouldn't provide it directly. You would have to get it from a previous function call.
Also, I think the cursor header isn't always set, so that whole logic probably needs to be checked.
Basically there are 2 code paths on the serverside for pagination, and I'm trying to separate them in the event we have other errors with it.
I kinda wish the API just used the same system for both.
Description
Resolves #576
Test Plan
Added pagination tests for both calls
Related Links
Checklist
pnpm fmt?CHANGELOG.md?