[aptos-workspace-server] various fixes and improvements #15571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 51m total CI duration on this PR
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
aptos-move/aptos-workspace-server/src/services/docker_common.rs
Outdated
Show resolved
Hide resolved
vgao1996
changed the title
banool
approved these changes
Dec 18, 2024
| future::Future, | ||
| net::{IpAddr, Ipv4Addr}, | ||
| sync::Arc, | ||
| }; | ||
|
|
||
| /// An wrapper to ensure propagation of chain of errors. |
There was a problem hiding this comment.
nit
Suggested change
| /// An wrapper to ensure propagation of chain of errors. | |
| /// A wrapper to ensure propagation of chain of errors. |
Comment on lines
+204
to
+205
| #[arg(long, default_value_t = 1800)] | ||
| timeout: u64, |
There was a problem hiding this comment.
A comment and maybe better naming could be nice here. My first thought was that this would be a startup or shutdown timeout, but it really seems like a "max lifespan".
I don't fully know exactly how you use workspace, but I suppose there is a good reason that we always do this, vs making it optional?
There was a problem hiding this comment.
Also it'd be good to suffix whatever name we choose with _secs
| bollard::errors::Error::DockerResponseServerError { | ||
| status_code: 409, .. | ||
| } => { | ||
| println!("Docker network {} already exists, not creating it", name); |
|
|
||
| handle | ||
| .await | ||
| .map_err(|err| anyhow!("failed to join task handle: {}", err))? |
There was a problem hiding this comment.
Suggested change
| .map_err(|err| anyhow!("failed to join task handle: {}", err))? | |
| .map_err(|err| anyhow!("failed to join task handle: {:#}", err))? |
I think this is the best way to get the most context? Not 100% sure though.
| }, | ||
| Err(_err) => { | ||
| println!( | ||
| "Docker image {} does not exist. Pulling image..", |
There was a problem hiding this comment.
tiny nit
Suggested change
| "Docker image {} does not exist. Pulling image..", | |
| "Docker image {} does not exist. Pulling image...", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several fixes and improvements to
aptos-workspace-server: