Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix txn-emitter precission of worker sleeping #15552

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 10, 2024

⏱️ 1h 32m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
test-target-determinator 9m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 5m 🟩🟩🟩
check 5m 🟩🟥
check-dynamic-deps 5m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
general-lints 1m 🟩🟩🟩
file_change_determinator 47s 🟩🟩🟩🟩
file_change_determinator 23s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos enabled auto-merge (squash) December 13, 2024 23:06
async fn sleep_check_done(&self, duration: Duration) {
let start_time = Instant::now();
async fn sleep_check_done(&self, sleep_until_time: Instant) {
// sleep has milisecond granularity - so round the sleep
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: milisecond should be millisecond. The comment is otherwise clear and accurate about the sleep granularity.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/txn_emitter_sleep_fix branch from d17b0ec to d08b196 Compare December 17, 2024 16:24

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> d08b196030e68f28694f4b6f2cfde6fcee1da824

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> d08b196030e68f28694f4b6f2cfde6fcee1da824 (PR)
1. Check liveness of validators at old version: 34025227eb5367c449bf9dae3cd226fe5c187904
compatibility::simple-validator-upgrade::liveness-check : committed: 15903.70 txn/s, latency: 2188.66 ms, (p50: 2100 ms, p70: 2100, p90: 3000 ms, p99: 5100 ms), latency samples: 515880
2. Upgrading first Validator to new version: d08b196030e68f28694f4b6f2cfde6fcee1da824
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6848.95 txn/s, latency: 4430.84 ms, (p50: 5100 ms, p70: 5400, p90: 5600 ms, p99: 5700 ms), latency samples: 127820
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6541.75 txn/s, latency: 5098.51 ms, (p50: 5500 ms, p70: 5600, p90: 5700 ms, p99: 5800 ms), latency samples: 226980
3. Upgrading rest of first batch to new version: d08b196030e68f28694f4b6f2cfde6fcee1da824
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7104.90 txn/s, latency: 4261.65 ms, (p50: 4900 ms, p70: 5200, p90: 5300 ms, p99: 5500 ms), latency samples: 131200
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6951.71 txn/s, latency: 4820.48 ms, (p50: 5200 ms, p70: 5300, p90: 5400 ms, p99: 5500 ms), latency samples: 236280
4. upgrading second batch to new version: d08b196030e68f28694f4b6f2cfde6fcee1da824
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12206.08 txn/s, latency: 2382.99 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 3500 ms), latency samples: 219780
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12261.35 txn/s, latency: 2676.36 ms, (p50: 2800 ms, p70: 2900, p90: 3100 ms, p99: 3300 ms), latency samples: 398460
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> d08b196030e68f28694f4b6f2cfde6fcee1da824 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d08b196030e68f28694f4b6f2cfde6fcee1da824

two traffics test: inner traffic : committed: 14698.33 txn/s, latency: 2705.60 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5588620
two traffics test : committed: 99.96 txn/s, latency: 1350.92 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2100 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.713, avg: 1.567", "ConsensusProposalToOrdered: max: 0.303, avg: 0.292", "ConsensusOrderedToCommit: max: 0.297, avg: 0.289", "ConsensusProposalToCommit: max: 0.598, avg: 0.581"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.73s no progress at version 1578767 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.61s no progress at version 2165160 (avg 0.61s) [limit 16].
Test Ok

@igor-aptos igor-aptos merged commit ac9302a into main Dec 18, 2024
47 of 48 checks passed
@igor-aptos igor-aptos deleted the igor/txn_emitter_sleep_fix branch December 18, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants