Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemState, StateAuthenticator #15236

Closed
wants to merge 1 commit into from
Closed

InMemState, StateAuthenticator #15236

wants to merge 1 commit into from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Nov 7, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 7, 2024 •
edited
Loading

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 9m 🟩 
rust-cargo-deny 2m 🟩 
check-dynamic-deps 42s 🟩 
general-lints 27s 🟩 
semgrep/ci 24s 🟩 
file_change_determinator 12s 🟩 
permission-check 3s 🟩 
permission-check 2s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@msmouse msmouse changed the title remove Hash impl for WriteSet family InMemState, StateAuthenticator Nov 7, 2024
@msmouse msmouse force-pushed the 1028-alden-state-auth branch from 58cde75 to 9c69bbf Compare November 21, 2024 03:23
@msmouse msmouse force-pushed the 1028-alden-state-auth branch from 9c69bbf to c88743f Compare November 22, 2024 18:06
@msmouse
Copy link
Contributor Author

msmouse commented Dec 18, 2024

finalized in #15411

@msmouse msmouse closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msmouse