Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to forge-stable test suite #14775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 27, 2024

⏱️ 10m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 3m 🟩
forge-realistic-env-fairness-workload-sweep / forge 2m 🟥
rust-cargo-deny 2m 🟩
rust-move-tests 2m 🟩
determine-test-metadata 2m 🟩
semgrep/ci 27s 🟩
general-lints 26s 🟩
file_change_determinator 9s 🟩
permission-check 7s 🟩
permission-check 4s 🟩
permission-check 3s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +117%
general-lints 26s 1m -71%

settingsfeedbackdocs ⋅ learn more about trunk.io

# * chain progress - checking longest pause between the blocks (both in num failed runs, and in absolute time) across the run
# * catchup - that all nodes can go over the same version at the end of the load (i.e. catching if any individual validator got stuck)
# * no restarts - fails if any node has restarted within the test
# * system metrics - checks for CPU and RAM utilization during the test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - add network bandwidth metric check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disk iops?

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Nov 18, 2024
@github-actions github-actions bot closed this Dec 3, 2024
@igor-aptos igor-aptos removed the Stale label Dec 17, 2024
@igor-aptos igor-aptos reopened this Dec 17, 2024
@igor-aptos igor-aptos force-pushed the igor/forge_documentation branch from 54395db to 0da1d72 Compare December 17, 2024 21:46
@igor-aptos igor-aptos force-pushed the igor/forge_documentation branch from 0da1d72 to b3b4b09 Compare December 17, 2024 22:00
@igor-aptos igor-aptos added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants