-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[execution window] use blocking txn provider #14584
Draft
bchocho
wants to merge
1
commit into
brian/exec-window-exec-base
Choose a base branch
from
brian/exec-window-exec-optimize-2
base: brian/exec-window-exec-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[execution window] use blocking txn provider #14584
bchocho
wants to merge
1
commit into
brian/exec-window-exec-base
from
brian/exec-window-exec-optimize-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 5h 28m total CI duration on this PR
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
changed the title
Brian/exec window exec optimize 2
[execution window] optimized 2
Sep 11, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-optimize
branch
from
September 25, 2024 17:27
16da500
to
893fde7
Compare
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
September 26, 2024 17:00
725d66e
to
3d99ab6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
changed the title
[execution window] optimized 2
[execution window] use blocking txn provider
Sep 26, 2024
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
September 30, 2024 18:41
3d99ab6
to
fac9a47
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
September 30, 2024 23:18
49ca098
to
b3d33c6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
October 16, 2024 18:07
88df965
to
5b71c29
Compare
bchocho
changed the base branch from
brian/exec-window-exec-optimize
to
brian/exec-window-exec-base
October 16, 2024 18:07
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
October 17, 2024 20:36
d0db51e
to
e395dca
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
October 30, 2024 18:20
e395dca
to
a3feb00
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bchocho
force-pushed
the
brian/exec-window-exec-base
branch
from
October 30, 2024 19:45
a0f2d39
to
7fd1415
Compare
bchocho
force-pushed
the
brian/exec-window-exec-base
branch
from
November 22, 2024 19:06
7fd1415
to
74de433
Compare
bchocho
force-pushed
the
brian/exec-window-exec-optimize-2
branch
2 times, most recently
from
December 3, 2024 18:32
e9aff6a
to
4419c21
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… round-1 in execution phase. This requires using blocking txn provider to quickly provide shuffled txns in the execution phase. Various improvements to avoid cloning transactions.
hariria
force-pushed
the
brian/exec-window-exec-optimize-2
branch
from
December 18, 2024 21:28
4419c21
to
20a72fe
Compare
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-failpoints-images
Build failpoints docker image
CICD:build-performance-images
build performance docker image variants
CICD:run-forge-e2e-perf
Run the e2e perf forge only
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes the prepare and execute stages for better performance for larger block windows. Mostly the optimizations are reducing the computation per transaction or number of transactions that have to be touched.
Prepare:
Execute:
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist