Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragroute fix to support fragmentation of IP datagrams that contain IP Total Length a 0 in header #247

Merged
merged 1 commit into from
May 13, 2016

Conversation

dsrana1212
Copy link

This fix is to support the fragmentation of IP datagrams generated by wireshark on windows systems that have TCP segmentation offloading to NIC enabled. In such systems, the IP fragmentation is done by NIC and the IP layer just passes the application data buffer to NIC and sets the IP Total Length field in header is set to 0. Since wireshark sniffs packets before they are properly fragmented by NIC, all these IP datagrams will have large payload with IP Total Length header field set to 0.

The fragroute code does fragmentation based on the IP Total Length field value and break the datagram in smaller fragments as specified by user. However, in current case,since IP total length is 0, the fragroute does not fragment the datagram even though the datagram contains huge payload.

Fix : check if the IP Total Lenght field is zero. If so then read the length of datagram from the incoming buffer length.

Tests : tested with wireshark captures containing valid IP Total Length and also with captures containing zero IP Total Length.

@fklassen
Copy link
Member

Thanks for the PR.

@fklassen fklassen merged commit 41be9ba into appneta:master May 13, 2016
@dsrana1212
Copy link
Author

No problem. This tool hass helped me a lot at my job:). Its time to give back:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants