Create directory before push to avoid permission issue #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the unit tests |
lib/tools/adb-commands.js
Outdated
| @@ -966,6 +966,7 @@ methods.rimraf = async function rimraf (path) { | |||
| * options. | |||
| */ | |||
| methods.push = async function push (localPath, remotePath, opts) { | |||
| await this.mkdir(path.dirname(remotePath)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushFileisn't working on some later versions of Android SDK.Was getting error
remote secure_mkdirs failed: Operation not permitted. Workaround is to create the directory first usingadb shell mkdirbefore pushing the file. That directory will have the correct permissions.(another issue that had this problem: bazelbuild/examples#77)