Add pathBuilder argument to @rest directive #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeyHugo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
I updated master with 5kb bundlesize if you want to go-fully green before PR review. Please ping me when you're ready for review here! |
HeyHugo
force-pushed
the
feature/pathBuilder
branch
from
e4af631 to
606d511
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 92.64% 92.82% +0.18%
==========================================
Files 2 2
Lines 231 237 +6
Branches 80 82 +2
==========================================
+ Hits 214 220 +6
Misses 17 17
Continue to review full report at Codecov.
|
HeyHugo
force-pushed
the
feature/pathBuilder
branch
from
606d511 to
46f4cd1
Compare
|
Ok, you can review now I think @fbartho |
pathBuilder is a user provided function via a graphql variable to build up the path string. A use case it enables is having one or more optional query string parameters e.g: "/items/filter?minPrice=5&maxPrice=20" Here minPrice and maxPrice could be omitted See proposal in apollographql#69 and the problem it solves in apollographql#67
HeyHugo
force-pushed
the
feature/pathBuilder
branch
from
46f4cd1 to
fb8483b
Compare
fbartho
approved these changes
Feb 19, 2018
|
Thanks a ton @HeyHugo ! |
This was referenced Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathBuilderis a user-provided function via a graphql variable to build up the path string.A use case it enables is having one or more optional query string parameters e.g:
/items/filter?minPrice=5&maxPrice=20
Here minPrice and maxPrice could be omitted
See proposal in #69 and the problem it solves in #67