-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: inline graphql-anywhere #301
chore: inline graphql-anywhere #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks pretty good! I haven't tested it yet myself, but do we see any reasons why this shouldn't merge?
@fbartho thanks for the review 😄 I also went through and updated the three examples so they build with the latest version of all dependencies, and so I could do a manual test against a local build of this PR. Everything looks good: SimpleAdvancedTypeScriptReproduction StepsIf anyone wants to pull this PR and do the same, these are the reproduction steps:
|
This is ready for a final pass 🙌 |
@fbartho just following up - I went ahead and updated the examples, but would be happy to move them to a separate PR if you prefer. |
No that's fine! |
Shipped this in v0.9.0! -- Enjoy! https://www.npmjs.com/package/apollo-link-rest/v/0.9.0 |
In light of the deprecation of
graphql-anywhere
in the course of releasing Apollo Client 3 in 2020, this PR inlines thegraphql
function previously imported fromgraphql-anywhere/lib/async
as well as typesResolver
andExecInfo
and removes all other references to the deprecated library.NB:
[email protected]
was published today with an updated peer dependency range for thegraphql
package to fix thenpm i
peer dependency error withgraphql@16
for npm7+ (apollographql/apollo-client#10114), and to include a deprecation notice.Feel free to close this PR in favor of continuing with
graphql-anywhere
now that the peer dependency issue is resolved, but thought I'd open it in case it's useful :) Thanks!