-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fieldNameNormalizer mangling ArrayBuffer/Blob types #247
Conversation
@TylorShin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
@TylorShin thanks for the PR -- do you have an urgent need for this? Currently, our plan is to ship Milestone 0.8.0 in Late May/Early June with compatibility for ApolloClient 3! Additionally, please sign the Apollo CLA so that we can consider this! |
Thanks for the quick reply! So, yes. I can wait for it until the new version coming. I'm looking forward to migrating. |
@TylerShin -- I know it's been almost a year, but I'm looking to ship the stable release next month! -- Since you've been working on a forked version of the repo, do you have any other features you want to contribute back? Sorry for the delay! |
@fbartho No I have not used Apollo for long time. It's totally okay. |
This will ship in v0.9.0 |
Shipped in the pre-release of 0.9.0-rc.1 please advise if you have any issues |
Shipped this in v0.9.0! -- Enjoy! https://www.npmjs.com/package/apollo-link-rest/v/0.9.0 |
Fix bug situation.
currently fieldNameNormalizer makes ArrayBuffer or Blob to {};
especially use it with responseTransformer.
for example,
after using
useQuery
, data always return {};Because
convertObjectKeys
function thinks ofBlob
ofArrayBlob
as a normalObject
that could be serialized.