Various edits to caching docs #9984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenBarlow
commented
Aug 4, 2022
StephenBarlow
commented
Aug 4, 2022
StephenBarlow
commented
Aug 4, 2022
| @@ -82,19 +87,19 @@ const cache = new InMemoryCache({ | |||
| If a field requires numerous parameters then each parameter must be wrapped in a variable that is then destructured and returned. | |||
There was a problem hiding this comment.
I'm not entirely clear what this paragraph is trying to say in its current form, which prevented me from suggesting edits.
StephenBarlow
commented
Aug 4, 2022
StephenBarlow
commented
Aug 4, 2022
|
@StephenBarlow is there anything you need from the team here? |
|
@bignimbus Ahh I'll need to review this PR to remind myself what it includes, which I probably can't do for a bit. Will follow up when possible! |
StephenBarlow
force-pushed
the
sb/caching-doc-edits
branch
from
e23cd3d to
a164b72
Compare
added 2 commits
October 11, 2022 15:26
StephenBarlow
force-pushed
the
sb/caching-doc-edits
branch
from
a164b72 to
0cdd121
Compare
|
Okay in updating and re-reviewing this PR, it looks entirely uncontroversial and just copy/structure related, so I'm going to go ahead and merge 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.