Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll interval docs update #9687

Merged
merged 3 commits into from
May 6, 2022
Merged

Poll interval docs update #9687

merged 3 commits into from
May 6, 2022

Conversation

jpvajda
Copy link
Contributor

@jpvajda jpvajda commented May 5, 2022

This PR:

@jpvajda jpvajda requested a review from StephenBarlow as a code owner May 5, 2022 23:38
@jpvajda jpvajda mentioned this pull request May 5, 2022
Closed
@jpvajda jpvajda self-assigned this May 5, 2022
@jpvajda jpvajda requested review from brainkim and benjamn May 5, 2022 23:44
StephenBarlow
StephenBarlow approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from here if it better conforms to modern syntax expectations!

@jpvajda
Copy link
Contributor Author

jpvajda commented May 5, 2022

@StephenBarlow well it's a bit a of ongoing JS debate to use ' or " 😄 but I relied on this doc for guidance

@jpvajda jpvajda merged commit 45d1e0f into main May 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenBarlow StephenBarlow StephenBarlow approved these changes

@brainkim brainkim Awaiting requested review from brainkim

@benjamn benjamn Awaiting requested review from benjamn

Assignees

@jpvajda jpvajda

Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpvajda @StephenBarlow