-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Support useMutation client param passed to execute function #9438
Fix: Support useMutation client param passed to execute function #9438
Conversation
@dciesielkiewicz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 4341208 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this contribution @dciesielkiewicz 🎉 🎉 .
Really good catch on this being allowed via types, but not used at runtime. We'll get this in the next patch release!
✅ Deploy Preview for apollo-client-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Motivation and context:
Our team found that according to types useMutation hook should support
client
prop passed to execute function, but in practice it only supports client prop passed to useMutation hook, only. Here is a fixChecklist: