Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Support useMutation client param passed to execute function #9438

Conversation

dciesielkiewicz
Copy link
Contributor

Motivation and context:

Our team found that according to types useMutation hook should support client prop passed to execute function, but in practice it only supports client prop passed to useMutation hook, only. Here is a fix

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@dciesielkiewicz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@jpvajda jpvajda added the 🏓 awaiting-contributor-response requires input from a contributor label May 3, 2022
@jpvajda jpvajda added 🏓 awaiting-team-response requires input from the apollo team and removed 🏓 awaiting-contributor-response requires input from a contributor labels May 5, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2023

🦋 Changeset detected

Latest commit: 4341208

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution @dciesielkiewicz 🎉 🎉 .

Really good catch on this being allowed via types, but not used at runtime. We'll get this in the next patch release!

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for apollo-client-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4341208
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/63f3e0249b914300081a4bc8
😎 Deploy Preview https://deploy-preview-9438--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jerelmiller jerelmiller merged commit 52a9c8e into apollographql:main Feb 20, 2023
@github-actions github-actions bot mentioned this pull request Feb 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏓 awaiting-team-response requires input from the apollo team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants