Added "Breaking Changes" to @apollo/react-hooks section #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a section to the `@apollo/react-hooks` section that details two breaking changes that I encountered whilst upgrading a v2 app to v3. I believe calling out these changes will save other developers a lot of time debugging apps after they have migrated to v3.
|
@ctataryn: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
@StephenBarlow 👋 Just wanted to bring this to your attention. If you feel it could be improved, please let me know and I'll update. |
|
Ah, thank you @ctataryn this looks good! Sorry I missed it initially 🙏 |
StephenBarlow
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a section to the
@apollo/react-hookssection that details two breaking changes that I encountered whilst upgrading a v2 app to v3. I believe calling out these changes will save other developers a lot of time debugging apps after they have migrated to v3.Checklist:
- [ ] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)- [ ] Make sure all of the significant new logic is covered by tests