Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial data appearing in useQuery().data when notifyOnNetworkStatusChange: true #9367

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Fix partial data appearing in useQuery().data when notifyOnNetworkStatusChange: true #9367

merged 2 commits into from
Feb 1, 2022

Conversation

brainkim
Copy link
Contributor

@brainkim brainkim commented Jan 28, 2022 •
edited
Loading

Fixes #8715, fixes #9169, fixes #9291, fixes #9334 (dupes).

Introduced in #8642.

@brainkim brainkim requested a review from benjamn January 28, 2022 01:42
benjamn
benjamn approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Thanks for finding a way to test this and for fixing it with so few changes @brainkim.

@brainkim brainkim merged commit 108d652 into main Feb 1, 2022
@brainkim brainkim deleted the brian-fix-partialData branch February 1, 2022 15:55
@benjamn benjamn changed the title Fix partial data appearing in useQuery() when notifyOnNetworkStatusChange is true. Fix partial data appearing in useQuery().data when notifyOnNetworkStatusChange: true Feb 10, 2022
@benjamn benjamn added this to the v3.5.x patch releases milestone Feb 10, 2022
benjamn added a commit that referenced this pull request Feb 10, 2022
@benjamn
Mention PRs #9299 and #9367 in CHANGELOG.md.
178916f
@benjamn
Copy link
Member

benjamn commented Feb 15, 2022

These changes should now be available from npm in @apollo/[email protected] (just published).

@hueter
Copy link

hueter commented Feb 15, 2022

thanks so much @brainkim - this fix let my team successfully upgrade from 3.4.6 to the 3.5.9 with no CI failures 💯

@benasher44 benasher44 mentioned this pull request Mar 22, 2022
Open
This was referenced Jun 22, 2022
Closed
Closed
@cpvdeveloper cpvdeveloper mentioned this pull request Nov 1, 2022
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.x patch releases
3 participants
@brainkim @benjamn @hueter