Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass along missing field errors to the user #8262

Merged
merged 3 commits into from
May 20, 2021
Merged

pass along missing field errors to the user #8262

merged 3 commits into from
May 20, 2021

Conversation

brainkim
Copy link
Contributor

“Fixes“ #8063 by exposing missing field errors.

@brainkim brainkim requested review from benjamn and hwillson May 19, 2021 01:18
brainkim
brainkim commented May 19, 2021
View reviewed changes
src/errors/index.ts
@@ -36,6 +38,7 @@ const generateErrorMessage = (err: ApolloError) => {
export class ApolloError extends Error {
public message: string;
public graphQLErrors: ReadonlyArray<GraphQLError>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider Readonly to be a “bad part” of TypeScript but I’m not gonna rock the boat here.

hwillson
hwillson approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @brainkim! (maybe just add a quick note in the CHANGELOG as well) Thanks!

@brainkim brainkim force-pushed the brian-pass-missing branch from 9e94817 to e2d336f Compare May 19, 2021 18:04
@brainkim brainkim mentioned this pull request May 19, 2021
Closed
@brainkim brainkim force-pushed the brian-pass-missing branch from e2d336f to 8fa3797 Compare May 20, 2021 17:33
@brainkim brainkim requested a review from StephenBarlow as a code owner May 20, 2021 17:33
@brainkim brainkim changed the base branch from main to release-3.4 May 20, 2021 17:33
@brainkim brainkim force-pushed the brian-pass-missing branch from 8fa3797 to 2de299a Compare May 20, 2021 17:35
benjamn
benjamn approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to push one commit before you merge (see comment below).

src/cache/core/types/common.ts Outdated Show resolved Hide resolved
@benjamn
Copy link
Member

benjamn commented May 20, 2021

@brainkim Feel free to merge (assuming you're ok with 9ec7f17)!

@brainkim brainkim merged commit 9b6d276 into release-3.4 May 20, 2021
@brainkim brainkim deleted the brian-pass-missing branch May 20, 2021 18:04
This was referenced Aug 5, 2021
Closed
Merged
sqs added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Jan 27, 2022
@sqs
WIP upgrade @apollo/client to fix useQuery returning data===undefined…
bfee38e 
… problem

apollographql/apollo-client#7128
apollographql/apollo-client#8262
apollographql/apollo-client#8063
@bignimbus bignimbus mentioned this pull request Nov 7, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@benjamn benjamn benjamn approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brainkim @benjamn @hwillson