Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apollo-link-observable to community links #8234

Merged
merged 3 commits into from
May 12, 2022

Conversation

dragozin
Copy link
Contributor

PR description

Add information about apollo-link-observable to client docs.

About the link

Link that allows you to make side effects of graphql queries using RxJS

Motivation for creating the link

  1. Organization of application side effects such as logging, accessing the browser cache, recording analytics events etc.
  2. A part of the application with longer lifecycle than a component's one.
  3. Creating a complex application business logic.
  4. Performing REST queries as a reaction to the graphql query.
  5. Local state changes that are triggered by graphql queries.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@dragozin dragozin requested a review from StephenBarlow as a code owner May 16, 2021 12:59
@apollo-cla
Copy link

@dragozin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for wanting to add this to our community links, I had a question for you.

It's currently tagged as release 0.0.1 and there is no description and no recent updates to the code. I wanted to check if this project is still supported and if you could validate it's ready to be publicly shared within our community links as it might drive a lot of interest to the project.

@jpvajda jpvajda added the 🏓 awaiting-contributor-response requires input from a contributor label May 12, 2022
@jpvajda jpvajda self-assigned this May 12, 2022
@dragozin
Copy link
Contributor Author

Hi, @jpvajda!

Thank you for your interest in my PR! This is the first release and I'm using the link in my projects. I suppose it might be helpful to other people. I have a description with motivation and examples of use here : https://github.com/dragozin/apollo-link-observable#readme . The project is currently supported by me.

@jpvajda
Copy link
Contributor

jpvajda commented May 12, 2022

@dragozin Thanks for the quick response! We'd be happy to add it to the community links! Thanks for putting in the effort to help Apollo Client users leverage RxJS.

@jpvajda jpvajda removed the 🏓 awaiting-contributor-response requires input from a contributor label May 12, 2022
@jpvajda jpvajda merged commit 79c9db1 into apollographql:main May 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants