Avoid warning about clobbering scalar fields. #7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is possible to write a field merge function that handles updates for scalar field values, we should treat scalar data as opaque by default, without displaying "Cache data may be lost..." warnings that nudge the developer to write an unnecessary merge function. None: because this code is inside of a process.env.NODE_ENV block, it will not be executed or bundled in production. Should fix #7071.
benjamn
force-pushed
the
7071-no-warning-for-scalar-field-update
branch
from
db67108 to
a4f9ca5
Compare
benjamn
commented
Sep 25, 2020
Comment on lines
286
to
+294
| if (process.env.NODE_ENV !== "production") { | ||
| const hasSelectionSet = (storeFieldName: string) => | ||
| fieldsWithSelectionSets.has(fieldNameFromStoreName(storeFieldName)); | ||
| const fieldsWithSelectionSets = new Set<string>(); | ||
| workSet.forEach(selection => { | ||
| if (isField(selection) && selection.selectionSet) { | ||
| fieldsWithSelectionSets.add(selection.name.value); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Because this code is inside of a process.env.NODE_ENV !== "production" block, it will not be executed or bundled in production.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to write a custom
mergefunction that handles updates for scalar field values, we should treat scalar data as opaque by default, without displayingCache data may be lost...warnings (#6372) that nudge the developer to write an unnecessarymergefunction.In this context, scalar data means any subtree of a
GraphQLresult object for which the corresponding field in the query does not have a selection set. In particular, JSON data may look like any other GraphQL object, but it should be treated as an opaque value if the query does not apply a nested selection set to the field that holds the JSON data.Should fix #7071.