Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid mutating incoming data in Policies#applyMerges. #6276

Merged
merged 1 commit into from
May 13, 2020
Merged

Avoid mutating incoming data in Policies#applyMerges. #6276

merged 1 commit into from
May 13, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented May 13, 2020

Almost certainly fixes #6245, though I couldn't find a way to reproduce the original problem using ...existing syntax as @3nvi suggested.

@benjamn benjamn self-assigned this May 13, 2020
@benjamn benjamn added this to the Release 3.0 milestone May 13, 2020
@benjamn benjamn requested a review from hwillson May 13, 2020 18:39
hwillson
hwillson approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @benjamn!

@benjamn benjamn merged commit 12637db into master May 13, 2020
@benjamn benjamn deleted the 6245-spread-existing-object-in-merge-function branch May 13, 2020 18:51
@benjamn benjamn mentioned this pull request May 28, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees

@benjamn benjamn

Labels
🐞 bug 🧪 has-tests 🧩 implementation-detail
Projects
None yet
Milestone
Release 3.0
Development

Successfully merging this pull request may close these issues.

Apollo v3 merge function fails when spreading existing non-normalized data
2 participants
@benjamn @hwillson