Allow setting new ApolloLink after ApolloClient instantiation #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides support for setting a new `ApolloLink` (or link chain) after `new ApolloClient()` has been called, using a public `ApolloClient.setLink()` method.
benjamn
changed the title
Moniv9
reviewed
May 10, 2021
| * Define a new ApolloLink (or link chain) that Apollo Client will use. | ||
| */ | ||
| public setLink(newLink: ApolloLink) { | ||
| this.link = this.queryManager.link = newLink; |
There was a problem hiding this comment.
Curious, why this.link is used. As observing a bug because of it. The chain keeps on adding because of this.
There was a problem hiding this comment.
@Moniv9 please open a separate issue with your details and a small runnable reproduction.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for setting a new
ApolloLink(or link chain) afternew ApolloClient()has been called, using a publicApolloClient.setLink()method.This is a follow up of #3877, and a continuation of #4297.