Perform all DocumentNode transforms once, and cache the results. #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of this work was previously duplicated for every request, which was not only wasteful for obvious reasons, but also limited the benefits of caching based on DocumentNode references, since repeatedly transforming the same document changes its referential identity, making it hard to tell whether a given document has been encountered before.
benjamn
commented
Mar 18, 2019
| @@ -689,6 +682,63 @@ export class QueryManager<TStore> { | |||
| }; | |||
| } | |||
|
|
|||
| private transformCache = new WeakMap<DocumentNode, Readonly<{ | |||
There was a problem hiding this comment.
We had to stop using WeakMap in #3394 because the React Native Android polyfill for WeakMap is especially broken, so I think we may need to find a way to use a Map here instead, ideally only when running in React Native. I'll work on that tomorrow.
Map should be fine for the purposes of this code. In fact, caching the transforms in a consolidated way probably has a bigger memory impact than using a WeakMap.
Not all environments where WeakMap must be polyfilled do so reliably: #3394 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of this work was previously duplicated for every request, which was not only wasteful for obvious reasons, but also limited the benefits of caching based on
DocumentNodereferences, since repeatedly transforming the same document changes its referential identity, making it hard to tell whether a given document has been encountered before.