unify algorithms for masking and migration

[phryneas]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: dd9004f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

✅ Docs Preview Ready

No new or changed pages found.

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12139

commit: dd9004f

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	40.78 KB (+0.29% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	51.04 KB (-0.18% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.9 KB (+0.52% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.3 KB (-0.2% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.7 KB (+0.33% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.71 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.85 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.43 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.36 KB (0%)
import { useFragment } from "dist/react/index.js"	2.37 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[jerelmiller]

Some things I see and wonder why I didn't think of it sooner 😆. Nice!

[jerelmiller]

Going to push a few minor updates before merging, but otherwise this looks great! Looking forward to getting this in. Thanks for the assist 🙂

[jerelmiller]

Suggested change

	path: string | undefined,
	migration: boolean
	migration: boolean,
	path?: string | undefined,

I think it might make sense to flip these around, which means we can keep path optional. Since migration is required anyways, might as well reduce a required argument in those areas we pass undefined anyways. Should reduce a touch of bundle size.

[jerelmiller]

Love this refactor!

Probably petty, but now that we aren't passing data as the first argument, can we swap the value and fieldName arguments? Right now it feels inverse to me and my brain breaks 🤣

[phryneas]

Switch around as you like :) I just wanted to keep data out to prevent potential memory leaks, and started writing to value so we don't keep a reference to the original value around forever