Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data masking] Fix issue applying accessor warnings to interface types #12130

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jerelmiller
Copy link
Member

Fixes #12127

Fixes error thrown when trying to apply accessor warnings to selection sets with inline fragment nodes. I did not previously check the fragment condition before trying to apply the additional selection set, so data would be undefined in those conditions.

@jerelmiller jerelmiller requested a review from phryneas November 14, 2024 18:42
@svc-apollo-docs
Copy link

svc-apollo-docs commented Nov 14, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 03a6171

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jerelmiller jerelmiller changed the base branch from main to release-3.12 November 14, 2024 18:42
Copy link

pkg-pr-new bot commented Nov 14, 2024

npm i https://pkg.pr.new/@apollo/client@12130

commit: 03a6171

Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.6 KB (+3.24% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 51.01 KB (+6.25% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.56 KB (+4.31% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.32 KB (+5.57% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.55 KB (+3.93% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (+0.24% 🔺)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (+0.4% 🔺)
import { useQuery } from "dist/react/index.js" 5.21 KB (+0.04% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (+0.05% 🔺)
import { useLazyQuery } from "dist/react/index.js" 5.71 KB (+0.21% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (+0.19% 🔺)
import { useMutation } from "dist/react/index.js" 3.62 KB (+0.11% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.85 KB (+0.11% 🔺)
import { useSubscription } from "dist/react/index.js" 4.43 KB (+0.09% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (+0.09% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (+0.04% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (+0.12% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (+0.1% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (+0.11% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (+0.12% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (+0.14% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.42 KB (+0.21% 🔺)
import { useReadQuery } from "dist/react/index.js" (production) 3.36 KB (+0.24% 🔺)
import { useFragment } from "dist/react/index.js" 2.33 KB (+2.23% 🔺)
import { useFragment } from "dist/react/index.js" (production) 2.28 KB (+2.19% 🔺)

@jerelmiller jerelmiller changed the title [Data masking] Fix issue applying [Data masking] Fix issue applying accessor warnings to interface types Nov 14, 2024
@jerelmiller jerelmiller added the 🎭 data-masking Issues/PRs related to data masking label Nov 15, 2024
@jerelmiller jerelmiller added this to the Data masking milestone Nov 15, 2024
@jerelmiller jerelmiller merged commit 1e7d009 into release-3.12 Nov 15, 2024
41 of 45 checks passed
@jerelmiller jerelmiller deleted the jerel/fix-unmask-migrate-bug branch November 15, 2024 17:30
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
This was referenced Dec 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-cleanup 🤖 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data masking] Error when adding unmask warnings on interface types
2 participants