Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t prompt for DevTools installation for browser extension page #11838

Merged
merged 4 commits into from
May 13, 2024

Conversation

alex-kinokon
Copy link
Contributor

Fixes #11382.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@apollo-cla
Copy link

@alex-kinokon: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented May 10, 2024

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bb05cd2

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: bb05cd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks great to me and seems in line with what React DevTools do.

Thanks a bunch for the contribution!

@jerelmiller
Copy link
Member

@alex-kinokon don't worry about the integration test failure. I'm seeing the same thing in another PR of mine. Once we figure that out for the main branch, I'd be happy to merge this.

phryneas and others added 2 commits May 13, 2024 14:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jerelmiller jerelmiller merged commit 8475346 into apollographql:main May 13, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don’t prompt for DevTools installation for browser extension page
4 participants