-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchFragment
fixes
#11754
watchFragment
fixes
#11754
Conversation
🦋 Changeset detectedLatest commit: b9477c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
/release:pr |
size-limit report 📦
|
A new release has been made for this PR. You can install it with:
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/core/ApolloClient.ts
Outdated
@@ -239,6 +239,7 @@ export class ApolloClient<TCacheShape> implements DataProxy { | |||
this.watchQuery = this.watchQuery.bind(this); | |||
this.query = this.query.bind(this); | |||
this.mutate = this.mutate.bind(this); | |||
this.watchQuery = this.watchQuery.bind(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.watchQuery = this.watchQuery.bind(this); | |
this.watchFragment = this.watchFragment.bind(this); |
Did you mean to write this? I think this was your intention based on the changelog 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So weird! Yes, I definitely meant watchFragment
there 🥲
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you'll update the constructor as you see fit 🙂. Good catch!
/release:pr |
A new release has been made for this PR. You can install it with:
|
Glad I started implementing the integration with
apollo-angular
because I found some minor issues :)