-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable react-hooks
lint rules
#11511
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2d5f02f
enable `react-hooks` lint rules
phryneas 913ea1f
Merge remote-tracking branch 'origin/main' into pr/lint-hooks
phryneas 9e786aa
Clean up Prettier, Size-limit, and Api-Extractor
phryneas d757781
update eslint rule
phryneas 0e5e3cb
different type casting to not break lint rule parsing
phryneas 6ad1b0e
fix up useMutation + lifecycle test
phryneas 172f26c
Clean up Prettier, Size-limit, and Api-Extractor
phryneas c5a5d28
avoid reading/writing ref in render
phryneas 6070945
fix up useLazyQuery
phryneas 9c78b5c
Clean up Prettier, Size-limit, and Api-Extractor
phryneas 8a33815
fix up another test doing a mutation in render
phryneas 1aeb9ff
more useQuery cleanup
phryneas c34a48c
Clean up Prettier, Size-limit, and Api-Extractor
phryneas 34ef7d8
ignore rule of hook for context access
phryneas c5bb497
undo changes that were moved into separate PRs
phryneas 8cdba15
Clean up Prettier, Size-limit, and Api-Extractor
phryneas 2e751e1
almost full rewrite of the `useSubscription` hook
phryneas d70b45e
Clean up Prettier, Size-limit, and Api-Extractor
phryneas 0c813a1
ignore any rule violation lint warnings in useSubscription and useQuery
phryneas e9c247b
changeset
phryneas 619b188
rename patch
phryneas 7743e0b
Merge remote-tracking branch 'origin/main' into pr/lint-hooks
phryneas 694452f
also add "eslint-plugin-react-compiler" rules
phryneas 9eaa883
Merge branch 'main' into pr/lint-hooks
phryneas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
different type casting to not break lint rule parsing
- Loading branch information
commit 0e5e3cb5681d2cf7d0dc2076cf56db6923f45eb0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint rule had massive problems parsing the
satisfies ... as
pattern, but this works.