Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map React.Context instances by React.createContext #11026

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

phryneas
Copy link
Member

For reference, using React.version as a key caused problems over in react-redux for people who used multiple versions of preact that all report the React version 17.0.2.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests (I'd rather not add an integration test with multiple versions of preact)

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 6084b58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.03 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.64 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.63 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.31 KB (+0.76% 🔺)
import { useQuery } from "dist/react/index.js" 4.34 KB (+0.25% 🔺)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (+0.15% 🔺)
import { useMutation } from "dist/react/index.js" 2.57 KB (+0.31% 🔺)
import { useSubscription } from "dist/react/index.js" 2.32 KB (+0.26% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 3.7 KB (+0.22% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 3.91 KB (+0.18% 🔺)
import { useReadQuery } from "dist/react/index.js" 2.64 KB (0%)
import { useFragment } from "dist/react/index.js" 2.12 KB (+0.28% 🔺)

@phryneas phryneas self-assigned this Jul 3, 2023
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this does this trick 🤞

@jerelmiller jerelmiller added this to the Release 3.8 milestone Jul 6, 2023
@phryneas phryneas merged commit b8d405e into release-3.8 Jul 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
@jerelmiller jerelmiller deleted the pr/context-mapByReference branch January 23, 2024 03:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants