Allow ApolloCache implementations to specify default value for assumeImmutableResults client option
#10567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b0a20b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjamn
added
🐎 performance
💡 idea
🧞♂️ enhancement
🧩 implementation-detail
🥚 backwards-compatible
jerelmiller
requested review from
jerelmiller,
phryneas and
alessbell
and removed request for
jerelmiller
alessbell
approved these changes
Mar 21, 2023
| throw new InvariantError( | ||
| "To initialize Apollo Client, you must specify a 'cache' property " + | ||
| "in the options object. \n" + | ||
| "For more information, please visit: https://go.apollo.dev/c/docs" |
There was a problem hiding this comment.
[Not material to this PR but] TIL that shortlink exists
There was a problem hiding this comment.
Yep, and we can add more short links if need be. It would be cool if each error had its own short link with more info.
jerelmiller
approved these changes
Mar 21, 2023
This commit allows the default value of the `assumeImmutableResults` option to be determined by the cache (any implementation of `ApolloCache`), which allows our implementation of `InMemoryCache` to express the safety of assuming `assumeImmutableResults` is `true`, unlocking significant performance savings (fewer defensive deep copies of query results), even if `assumeImmutableResults` is not configured. Related past PRs: - #4543 - #5153 - #9680 - [Apollo Client 2.6 blog post](https://www.apollographql.com/blog/announcement/frontend/whats-new-in-apollo-client-2-6/#rewarding-immutability)
benjamn
force-pushed
the
auto-detect-assumeImmutableResults
branch
from
1e82a21 to
2b0a20b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the default value of the
assumeImmutableResultsoption to be determined by the cache (any implementation ofApolloCache), which allows our implementation ofInMemoryCacheto express the safety of assumingassumeImmutableResultsistrue, unlocking significant performance savings (fewer defensive deep copies of query results), even ifassumeImmutableResultsis not configured.Related past PRs/context: