Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2984] Fix typos and add white background to priority tree image for better visibility in dark mode #503

Closed
wants to merge 1 commit into from

Conversation

kousei47747
Copy link

What is this PR for?

Fix typos in User & Group Resolution, Sorting Policies, Preemption and ACLs sections.

Changes:

  • labell => label
  • time stamp => timestamp
  • yunikorn-k8shim/deployment/example/preemption => yunikorn-k8shim/deployments/examples/preemption
  • This places some limitations on the how to escape the values. => This places some limitations on how to escape the values

Add white background to priority tree image for better visibility in dark mode.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2984

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

github-actions bot pushed a commit that referenced this pull request Nov 24, 2024
…riority tree image for better visibility in dark mode (#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants