-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2941] Remove plugin mode from the install section of Getting Started #494
Conversation
Maybe we should add a deprecated tag to it rather than delete it. |
…ll section of Get Started
@ryankert01 thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the versioned docs update (we never update these in order to preserve historical context). I'd also prefer to see the entire deployment modes section removed from the getting started guide as it just confuses things now that we're getting rid of plugin mode.
@craigcondit thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM.
…tion of Getting Started (#494)
What is this PR for?
Since plugin mode is now deprecated and will be removed in a future release, it would be better to remove the plugin mode in the install section to prevent any confusion.
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2941