Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2941] Remove plugin mode from the install section of Getting Started #494

Closed
wants to merge 7 commits into from

Conversation

kousei47747
Copy link

@kousei47747 kousei47747 commented Oct 21, 2024

What is this PR for?

Since plugin mode is now deprecated and will be removed in a future release, it would be better to remove the plugin mode in the install section to prevent any confusion.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2941

@ryankert01
Copy link
Contributor

Maybe we should add a deprecated tag to it rather than delete it.

@kousei47747 kousei47747 changed the title [YUNIKORN-2941] Remove the introduction of plugin mode from the install section of Get Started [YUNIKORN-2941] Add a deprecated tag to plugin mode in the install section of Get Started Oct 22, 2024
@kousei47747
Copy link
Author

@ryankert01 thanks for reviewing!
I've updated it to add a deprecated tag. Please check.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the versioned docs update (we never update these in order to preserve historical context). I'd also prefer to see the entire deployment modes section removed from the getting started guide as it just confuses things now that we're getting rid of plugin mode.

@kousei47747 kousei47747 changed the title [YUNIKORN-2941] Add a deprecated tag to plugin mode in the install section of Get Started [YUNIKORN-2941] Remove plugin mode from the install section of Getting Started Oct 25, 2024
@kousei47747
Copy link
Author

@craigcondit thanks for reviewing!
The versioned docs update and the entire deployment modes section in Getting Started have been removed, please check.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants