[SYSTEMDS-3801] missing method implementations in ColGroupSDCZeros #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e-strauss
commented
Dec 3, 2024
•
e-strauss
commented
- current master version breaks AWARE reproducibility experiment for kmeans+ algorithm
- missing methods implementations for DenseBlocks in ColGroupSDCZeros
- decreases runtime for kmeans+ algorithm on USCensus dataset from 40s to 32s
Baunsgaard
reviewed
Dec 3, 2024
src/main/java/org/apache/sysds/runtime/compress/colgroup/ColGroupSDCZeros.java
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/compress/colgroup/ColGroupSDCZeros.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2149 +/- ##
============================================
+ Coverage 71.83% 71.85% +0.01%
- Complexity 43755 43772 +17
============================================
Files 1441 1441
Lines 165971 165997 +26
Branches 32388 32393 +5
============================================
+ Hits 119227 119274 +47
+ Misses 37464 37452 -12
+ Partials 9280 9271 -9 ☔ View full report in Codecov by Sentry. |
fietenoer
pushed a commit
to fietenoer/systemds
that referenced
this pull request
Dec 5, 2024
The previous master version broke the AWARE experiment for the kmeans+ algorithm. This patch fixes that and adds missing methods implementations for DenseBlocks in ColGroupSDCZeros. After the changes, the runtime additionally was decreased from 40s to 32s for the kmeans+ algorithm on the US Census dataset. Closes apache#2149.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.