[SPARK-38279][TESTS][3.2] Pin MarkupSafe to 2.0.1 fix linter failure #35602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 22, 2022
Ngone51
approved these changes
Feb 22, 2022
|
I think we should better fix it in all branches to reduce conflicts at least, and it's a potential issue in any event. I will forward port this later when I merge. |
cloud-fan
approved these changes
Feb 22, 2022
dongjoon-hyun
approved these changes
Feb 22, 2022
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 22, 2022
### What changes were proposed in this pull request? This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below. ``` ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py) ``` Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly. See aws/aws-sam-cli#3661 for more detail. ### Why are the changes needed? To fix the CI failure on branch-3.2 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests are should be passed Closes #35602 from itholic/SPARK-38279. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 22, 2022
This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below. ``` ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py) ``` Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly. See aws/aws-sam-cli#3661 for more detail. To fix the CI failure on branch-3.2 No. The existing tests are should be passed Closes #35602 from itholic/SPARK-38279. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 79099cf) Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 22, 2022
This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below. ``` ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py) ``` Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly. See aws/aws-sam-cli#3661 for more detail. To fix the CI failure on branch-3.2 No. The existing tests are should be passed Closes #35602 from itholic/SPARK-38279. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 79099cf) Signed-off-by: Hyukjin Kwon <[email protected]>
|
Merged to master, branch-3.2, branch-3.1 and branch-3.0. |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below. ``` ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py) ``` Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly. See aws/aws-sam-cli#3661 for more detail. ### Why are the changes needed? To fix the CI failure on branch-3.2 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests are should be passed Closes apache#35602 from itholic/SPARK-38279. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to pin the Python package
markupsafeto 2.0.1 to fix the CI failure as below.Since
markupsafe==2.1.0has removedsoft_unicode,from markupsafe import soft_unicodeno longer working properly.See aws/aws-sam-cli#3661 for more detail.
Why are the changes needed?
To fix the CI failure on branch-3.2
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing tests are should be passed