Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong classpath in Espresso context #24912

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

linghengqian
Copy link
Member

For #24902.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian
Copy link
Member Author

@zhfeng

  • As a reminder, due to the incomplete changes in 7ee273d , the nativeTest of the Quarkus extension of ShardingSphere JDBC should not be able to be launched for 5.3.2. I didn't pay attention to this issue before.😢

@zhfeng
Copy link
Contributor

zhfeng commented Mar 30, 2023

@linghengqian Don't worry. I can wait for the next release and I tried to parse the groovy rules in the yaml config file at the build time. So I think quarkus-shardingsphere-jdbc might not be impacted by this issue.

Anyway, thanks a lot for taking care of native building. I see it is a very very tough work!

@linghengqian linghengqian marked this pull request as ready for review March 30, 2023 14:33
@TeslaCN TeslaCN merged commit 59c825f into apache:master Mar 30, 2023
@linghengqian linghengqian deleted the fix-javaclasspath branch March 30, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants