Merge pull request #1 from apache/master #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zmyer It looks like all changes in this PR are in. Can you please close this one? |
khandelwal-ayush
pushed a commit
to khandelwal-ayush/samza
that referenced
this pull request
Jun 12, 2024
apache#1697) (apache#43) * Create store directory paths in CSM constructor to be able to monitor the disk usage of the store directories * Fix stylecheck issues * Refactor - init all store paths together and do not mutate the storeDirPaths. Added test * Remove ununsed method * Remove ununsed method * Stylecheck, Remove ununsed import Co-authored-by: Shekhar Sharma <[email protected]>
khandelwal-ayush
pushed a commit
to khandelwal-ayush/samza
that referenced
this pull request
Jun 12, 2024
…e monitor (apache#1697) (apache#43)" (apache#44) This reverts commit 01534ff. The above commit introduces a type change that is causing all builds to fail on samza-li. e.g. see samza-li e8b00bcba88cf9d235f8432309ef60c6ae1c7d74 Revert that commit in the short-term until we can address the type mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge new version