Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception message in BlobStoreUtil's getSnapshotIndex #1712

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ajothomas
Copy link
Contributor

@ajothomas ajothomas commented Oct 11, 2024

Bug:
BlobStoreUtil's getSnapshotIndex method currently gets the SnapshotIndex blob using BlobStoreManager#get and deserializes it using SnapshotIndexSerde. We handle the exceptions encountered in the get step and deserialization step using the chained handle step.
The error log ,however, tells thats the exception was due to deserialization. This is incorrect as the handle will get exceptions from any of the previous steps i.e get and not just the deserialization step.

Changes:

  • Change handle message to reflect the correct exception message

Tests:

  • ./gradlew build
  • Added unit tests to assert if appropriate exception is thrown

API Changes:
None

Upgrade Instructions:
None

Usage Instructions:
None

@ajothomas ajothomas force-pushed the FixDeserErrorChaining branch from 4479c33 to ea7615d Compare October 15, 2024 19:52
@ajothomas ajothomas changed the title Fix throwing deserialization exceptions for SnapshotIndexBlobs Fix exception message in BlobStoreUtil's getSnapshotIndex Oct 15, 2024
Copy link
Contributor

@xinyuiscool xinyuiscool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update.

@ajothomas ajothomas merged commit 0cf9f9a into apache:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants