Add metrics for BlobNotFound error #1612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekm
requested changes
Jun 3, 2022
| * a blob that is not present. | ||
| * | ||
| */ | ||
| public class BlobNotFoundException extends RuntimeException { |
There was a problem hiding this comment.
NotFoundException to match naming convention for DeletedException etc.
| @@ -122,6 +125,8 @@ public BlobStoreBackupManager(JobModel jobModel, ContainerModel containerModel, | |||
| this.prevStoreSnapshotIndexesFuture = CompletableFuture.completedFuture(ImmutableMap.of()); | |||
| this.metrics = blobStoreTaskBackupMetrics; | |||
| metrics.initStoreMetrics(storesToBackup); | |||
| this.blobStoreManagerMetrics = blobStoreTaskManagerMetrics; | |||
| blobStoreTaskManagerMetrics.initStoreMetrics(storesToBackup); | |||
There was a problem hiding this comment.
Why are blob store manager metrics being passed and intialized here instead of in BlobStoreManager init?
There was a problem hiding this comment.
Same for all other occurences.
| this.dirDiffUtil = new DirDiffUtil(); | ||
| this.prevStoreSnapshotIndexes = new HashMap<>(); | ||
| this.loggedBaseDir = loggedBaseDir; | ||
| this.nonLoggedBaseDir = nonLoggedBaseDir; | ||
| this.taskName = taskModel.getTaskName().getTaskName(); | ||
| this.storesToRestore = storesToRestore; | ||
| this.metrics = metrics; | ||
| this.blobStoreRestoreManagerMetrics = metrics; | ||
| this.blobStoreManagerMetrics = blobStoreManagerMetrics; |
There was a problem hiding this comment.
Same as above, why is this updating metrics for an unrelated class?
| private static final String GROUP = BlobStoreManagerMetrics.class.getName(); | ||
| private final MetricsRegistry metricsRegistry; | ||
|
|
||
| public final Map<String, Gauge<Long>> storeBlobNotFoundError; |
There was a problem hiding this comment.
Why is this the only metric handled specially in blob store manager? What about get/put/delete count and timers etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: