-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-9889] [integration tests] Refactored Function integration tests #10140
Conversation
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
Add description for changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Awesome work!
@lhotari do you want to take a look?
I am not sure if there is some overlapping with your work.
BTW we can merge one of the two patches and then rebase the other one.
@david-streamlio can you fix the conflicts please? |
@freeznet Can you review this pull request? |
47aabbc
to
4d872cb
Compare
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
apache#10140) Co-authored-by: David Kjerrumgaard <[email protected]>
Fixes #9889
Motivation
Restructure the function integration tests for easier maintainability going forward
Modifications
I have broken out the existing test cases into separate classes based upon the type of Function we are trying to test, e.g Go, Java, Python, etc. Previously all of these tests were in a single class which violates OOP principles significantly
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation