Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-9889] [integration tests] Refactored Function integration tests #10140

Merged
merged 6 commits into from
May 11, 2021

Conversation

david-streamlio
Copy link
Contributor

@david-streamlio david-streamlio commented Apr 5, 2021

Fixes #9889

Motivation

Restructure the function integration tests for easier maintainability going forward

Modifications

I have broken out the existing test cases into separate classes based upon the type of Function we are trying to test, e.g Go, Java, Python, etc. Previously all of these tests were in a single class which violates OOP principles significantly

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (No)
  • The public API: (No)
  • The schema: (No)
  • The default values of configurations: (No)
  • The wire protocol: (No)
  • The rest endpoints: (No)
  • The admin cli options: (No)
  • Anything that affects deployment: (No)

Documentation

  • Does this pull request introduce a new feature? (No)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@david-streamlio
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@david-streamlio
Copy link
Contributor Author

/pulsarbot run-failure-checks

@aahmed-se
Copy link
Contributor

Add description for changes.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Awesome work!

@lhotari do you want to take a look?
I am not sure if there is some overlapping with your work.

BTW we can merge one of the two patches and then rebase the other one.

@eolivelli
Copy link
Contributor

@david-streamlio can you fix the conflicts please?

@sijie
Copy link
Member

sijie commented Apr 13, 2021

@freeznet Can you review this pull request?

@jerrypeng
Copy link
Contributor

/pulsarbot run-failure-checks

@david-streamlio
Copy link
Contributor Author

/pulsarbot run-failure-checks

@jerrypeng jerrypeng merged commit a161e75 into apache:master May 11, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the org.apache.pulsar.tests.integration.functions.PulsarFunctionsTest class
6 participants