Fix symbols conflict of OpenSSL. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Apr 6, 2023
5 tasks
shibd
added a commit
to streamnative/pulsar-client-node
that referenced
this pull request
Apr 9, 2023
(cherry picked from commit 91c2a15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Motivation
The root cause is the OpenSSL symbol conflict between Node.js and CPP client.
In versions after Node.js 17 or greater, the OpenSSL version was upgraded to 3.0.0, and the cpp client used v1.1.1 of Openssl.
Therefore, it results in a segmentation fault when users use TLS-related features.
Modifications
pulsar.node, use"-Wl,--exclude-libs,ALL"config to hidden symbol.Verifying this change
You can use this repo to verify it.
I have verified that the environment has:
Image:
BTW: I will add tls-relate unit test in subsequent PR.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)