-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][ci] change token name to GITHUB_TOKEN
#910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Although I suppose we can omit this env var at all and let the action read from preset ENV. But since it works and does no harm, let's move forward with this patch first.
A possible issue is that this default token may not have the write permission required and thus fail to write comment/update status on demand. You can check it (it may work differently from you personal fork and in the upstream) or we just give it a try. |
Yes, the behavior in the upstream repo may be different from my fork. So this pr may not work. Do you have any ideas to fix the bug about the CI bot? @tisonkun |
Some information about |
This change doesn't make the case worse. Let's give it a try. If it still won't work, we can find other approach or just remove the workflow since we actually live well without this functionality always. |
https://github.com/apache/pulsar-client-go/actions/runs/4698390864/jobs/8330614311 It seems default token doesn't have enough permission to trigger rerun. Although we can file an INFRA ticket to add one, but IIRC INFRA will reject configure personal access token as we do before - we may be an actual bot account. I'm OK to leave it as is or delete the workflow file since we can actually live well without this functionality. |
Fixes #909
Modifications
Change token to
GITHUB_TOKEN
.After changing, the pulsar bot works fine. Example here:
https://github.com/labuladong/pulsar-client-go/actions/runs/3681253024/jobs/6227745474#step:4:27