[DefaultRouter] add a parallel bench test #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can verify whether changes to the DefaultRouter have an impact on performance under concurrent load. Signed-off-by: Daniel Ferstay <[email protected]>
This was referenced Dec 27, 2021
dferstay
changed the title
cckellogg
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default router is called for every message published in the default configuration. Therefore, it must maintain a high level of performance in the face of code changes. Previously, we had a benchmark that measured serial routing performance, but we didn't have a way to measure performance of the router under parallel routing calls.
Modifications
Added a
BenchmarkDefaultRouterParallelbench test case todefault_router_bench_test.gomodule.Verifying this change
I ran the default router bench test module by hand from the pulsar sub-directory:
Does this pull request potentially affect one of the following parts:
Documentation