Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil pointer error with GetPartitionedTopicMetadata #536

Merged
merged 4 commits into from
Jun 15, 2021
Merged

fix nil pointer error with GetPartitionedTopicMetadata #536

merged 4 commits into from
Jun 15, 2021

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Jun 8, 2021 •
edited
Loading

Motivation

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xc7bd24]
goroutine 129 [running]:
github.com/apache/pulsar-client-go/pulsar/internal.(*lookupService).GetPartitionedTopicMetadata(0xc00017ac80, 0xc00040c1e0, 0x2c, 0x0, 0x0, 0x5)
	/go/pkg/mod/github.com/apache/[email protected]/pulsar/internal/lookup_service.go:193 +0x244
github.com/apache/pulsar-client-go/pulsar.(*client).TopicPartitions(0xc00010f860, 0xc00040c1e0, 0x2c, 0xc0005e6f80, 0x2, 0x2, 0xc0005e6f7c, 0x2)
	/go/pkg/mod/github.com/apache/[email protected]/pulsar/client_impl.go:184 +0xa2
github.com/apache/pulsar-client-go/pulsar.(*consumer).internalTopicSubscribeToPartitions(0xc0001d01a0, 0x0, 0x0)
	/go/pkg/mod/github.com/apache/[email protected]/pulsar/consumer_impl.go:250 +0x74
github.com/apache/pulsar-client-go/pulsar.(*consumer).runBackgroundPartitionDiscovery.func1(0xc0001280b0, 0xc00015c540, 0xc00017a190, 0xc0001d01a0)
	/go/pkg/mod/github.com/apache/[email protected]/pulsar/consumer_impl.go:237 +0xce
created by github.com/apache/pulsar-client-go/pulsar.(*consumer).runBackgroundPartitionDiscovery
	/go/pkg/mod/github.com/apache/[email protected]/pulsar/consumer_impl.go:229 +0xcd

Verifying this change

  • Make sure that the change passes the CI checks.

@freeznet freeznet force-pushed the freeznet/partition-metadata-response-nil-pointer-fix branch from 83581e8 to ddc53b3 Compare June 8, 2021 00:18
@freeznet
Copy link
Contributor Author

freeznet commented Jun 8, 2021

/pulsarbot run-failure-checks

@merlimat merlimat merged commit cb72395 into apache:master Jun 15, 2021
@merlimat merlimat added this to the 0.6.0 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cckellogg cckellogg cckellogg approved these changes

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@freeznet @merlimat @cckellogg