[fix #472] move GetPartitionedTopicMetadata to lookup service #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
wolfstudy
approved these changes
Mar 5, 2021
Hello @freeznet , currently the |
|
@freeznet and @wolfstudy - the original issue references an issue with the proxy. Was this bug limited to connections with the proxy or does it include connections to brokers as well? Thanks. |
@michaeljmarshall according to my tests, the issue only appears on proxy, and I havnt noticed the similar socket leakage issue with standalone pulsar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
Motivation
#472 addressed a socket leakage in go client. with some debug works, a difference between java client and go client was found. one difference is go client send
PartitionedTopicMetadatarequest with new connection, but java is using lookup service's connection. This pr addedGetPartitionedTopicMetadatato lookup service to reuse the lookup service connection.Through this pr, the leakage has been resolved with this sample deployment, the sockets are keep to 7 for 2 hours test. But still need to check with @KannarFr to see if there are any other possible leakages since I cannot have a cluster with 20 proxies/20 brokers/7 ZK locally.
Verifying this change