Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 367][producer] Send delay message individually even batching is enabled #372

Merged

Conversation

faycheng
Copy link
Contributor

@faycheng faycheng commented Sep 28, 2020

Fixes #367

Motivation

Send delay message individually even batching is enabled.

Modifications

  1. flush batching messages immediately when a new delay message is received
  2. reset deliverAtTime metadata of BatchBuilder

Verifying this change

Ref #367

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@faycheng faycheng closed this Sep 28, 2020
@faycheng faycheng reopened this Sep 28, 2020
@wolfstudy wolfstudy requested review from wolfstudy and merlimat and removed request for wolfstudy September 29, 2020 09:42
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faycheng The change LGTM+1, can you add a test case for this change?

@faycheng
Copy link
Contributor Author

@faycheng The change LGTM+1, can you add a test case for this change?

Sure.I will add a unit test.

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit afc040c into apache:master Oct 9, 2020
@wolfstudy wolfstudy added this to the 0.3.0 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A message without delay will reuse the delay of the previous message at the same producer
2 participants