Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #200] feature: add internal connectionReader readAtLeast error information #237

Merged
merged 1 commit into from
May 15, 2020
Merged

[Issue #200] feature: add internal connectionReader readAtLeast error information #237

merged 1 commit into from
May 15, 2020

Conversation

mileschao
Copy link
Contributor

Master Issue: #200

Motivation

add internal connectionReader readAtLeast error information
these error information may help to solve #200

Modifications

function readAtLeast return error type

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@mileschao
Copy link
Contributor Author

@sijie @wolfstudy
I've add some error information for #200
It help to solve problem. :-)

@mileschao
Copy link
Contributor Author

@sijie @wolfstudy
any idea about this?

wolfstudy
wolfstudy approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit b04a842 into apache:master May 15, 2020
@wolfstudy wolfstudy mentioned this pull request May 15, 2020
Closed
@wolfstudy wolfstudy added this to the 0.1.1 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@sijie sijie sijie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mileschao @sijie @wolfstudy