-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subscription expiration time namespace settings #1254
Add support for subscription expiration time namespace settings #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix the conflict
Thanks for the review @RobertIndie , I have fixed the merge conflicts |
Please take a look at this compilation error: https://github.com/apache/pulsar-client-go/actions/runs/10045685387/job/27779892242?pr=1254#step:5:30
|
Thanks, fixed @RobertIndie |
There are still some lint issues. If you are using macos or linux, you can run |
@RobertIndie thanks, fixed. Is there a way for me to run the build independently? It's a bit annoying that I cannot see what issues are failing the build until a maintainer triggers it. |
You can run |
That's great info, can it be added to the contributing guide? |
Fixes #1253
Motivation
Adds support for the get / set / delete
subscriptionExpirationTime
namespace settings.Modifications
Created new functions in
namespace.go
that implement support forsubscriptionExpirationTime
settingsVerifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation